This repository has been archived by the owner on Jun 1, 2023. It is now read-only.
component のディレクトリ構成を見直し #4016
Closed
component のディレクトリ構成を見直し #4016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nard-tech
commented
May 8, 2020
| import ConsultationDeskReportsNumberCard from '@/components/index/cards/ConsultationDeskReportsNumberCard.vue' | ||
| import MetroCard from '@/components/index/cards/MetroCard.vue' | ||
| import AgencyCard from '@/components/index/cards/AgencyCard.vue' | ||
|
|
There was a problem hiding this comment.
component の import が分散していたため，一箇所にまとめた
nard-tech
commented
May 8, 2020
Comment on lines
+17
to
+25
| <tested-cases-details-card | ||
| v-else-if="this.$route.params.card == 'details-of-tested-cases'" | ||
| /> | ||
| <inspection-persons-number-card | ||
| v-else-if="this.$route.params.card == 'number-of-inspection-persons'" | ||
| /> | ||
| <tested-number-card | ||
| v-else-if="this.$route.params.card == 'number-of-tested'" | ||
| /> |
There was a problem hiding this comment.
pages/index.vue での順序に合わせて変更
|
conflict が多すぎるため close し，新しく PR を作ることとします． cf. #2916 |
This was referenced Aug 22, 2020
Closed
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👏 解決する issue / Resolved Issues
⛏ 変更内容 / Details of Changes
component の変更が減ってきたので，上記 issue の内容を元に，以下の変更を行った
page/index.vueのみで使われているcomponents/以下のファイルを，components/index以下に移動するcomponents/cards/以下のファイルも，components/index/cards/に移動components/cards/でimportしている component（主にグラフ描画用のXxxxChart）をcomponents/index/cards/charts/に移動DataTable，TimeStackedBarChartの名称変更は行わなかった（再検討し，必要なら別途対応する）page/flow.vueのみで使われているcomponents/以下のファイルを，components/flow以下に移動（PrinterButtonのみ）SourceLinkは不使用のため削除した📸 スクリーンショット / Screenshots
画面上の変更はない